Backup Module

[Grut]

Hi,

I've noticed some problems with the backup module (maybe due to mysql5)
First, the xml file generated seems to be wrong.

For the sql file, there are some errors in it, I try to correct them:
- A comma is missing before the primary keys defintion, so I add line 116
$output .= "\r\n" . ' , PRIMARY KEY ( `'. implode('`, `', $primary) . '` )';
- The default value 'currenttimestamp' is malformed, so I add line 92
if ($details->has_default) {
if ($details->default_value == 'CURRENT_TIMESTAMP')
$output .= ' DEFAULT ' . $details->default_value . '()';
else
$output .= ' DEFAULT ' . "'$details->default_value'";
}

It's just a fix, but it seems to work.

Am I the only one with such worries with the backup module?

[Karen]

The backup module is pretty new and we are very hesitant about anybody using it for any serious backup purposes - hence the warnings plastered all over the associated documentation.

Thanks for identifying the issue - could you post it on the bug reporting system at as explained on http://docs.dotproject.net/index.php/Lodging_Bug_Reports

[Grut]

I tried to post it in the mantis but the backup module is missing in the list of module... not very easy to classify it.
So as soon as I can, I post an issue in the bug report.

Thanks.

[Karen]

I tried to post it in the mantis but the backup module is missing in the list of module... not very easy to classify it.
So as soon as I can, I post an issue in the bug report.

Thanks.

Whoops - there now.

[Grut]

Something else is missing in the mantis:
MySQL Version 5 in the database list... :)

Regards,
Yann Graufogel.

[Karen]

Tis now - thanks

[caseydk]

Yeah, I don't consider the backup module to be prepared for primetime... there were some major character encoding issues the last time I played with it.

If you're looking to backup your system, go the easy way: mysqldump

The best part is that this can be automated via cron, whatever.