Mileage Logs mod

[buckgee]

I am planning to create a mileage log module that will track:

- date/time
- odometer: start/end
- link to contact, project, task, helpdesk item or user entered notes

Reports for reporting.

Configuration area for cost per (km or mile)

[buckgee]

I have completed this mod. Let me know if anyone needs it.

[cyberhorse]

Post it as a patch on sf, and as a module on the forum below :) I am sure there would be other people interested in it.

[boardtc]

Do you think tho is might be modifable to create an expenses module?

Mileage (perhaps a better international term would be fuel consumption?) is commonly one component of expenses, along with accomodation, train/air travel, etc and sustenence (food).

What do you think?

[American]

Where can we download this mod?

[buckgee]

I posted this at sf in dotmods project patches area.

[jbresler]

Is anyone using this module? I'm running 2.0.1. The access, see, or edit others mileage logs doesn't work, I can only see my own. I've compared the permissions that I'm using to that of the timecard, so I'm feeling like my permissions are set correctly. Can someone take a look at this?
Thanks,
jb

[pedroa]

Eventually I will...

Pedro A.

[pedroa]

I have seen part of this in 28/6, quite awhile and I just can't remember what the heck I have done, but it is working decently.

Oh I remembered something, I had to had line on setup.php for the create table mileage_log after the:

`mileage_log_od_end` int(11) NOT NULL default '0',

add:

`mileage_log_miles` int(11) NOT NULL default '0',

Pedro A.

[gwp-1]

oK, I've installed it and I can see the MILEAGE LOG tab just fine. It's the "NEW/UPDATE LOG" tab that crashes:

ERROR: /home/.eeney/johnalan/johnalan.org/dotproject/includes/db_adodb.php(61): Error executing: SELECT DISTINCT(user_id), CONCAT_WS(', ', user_last_name, user_first_name) as full_name FROM users
LEFT JOIN permissions ON user_id = permission_user
WHERE permission_value IS NOT NULL
AND (user_id=2 or ( user_company in ('',0))) ORDER BY full_name
Backtrace:
0 /home/.eeney/johnalan/johnalan.org/dotproject/includes/db_adodb.php:61 dprint('/home/.eeney/johnalan/johnalan.org/dotproject/includes/db_adodb.php',61,0,'Error executing: SELECT DISTINCT(user_id), CONCAT_WS(\', \', user_last_name, user_first_name) as full_name FROM users
LEFT JOIN permissions ON user_id = permission_user
WHERE permission_value IS NOT NULL
AND (user_id=2 or ( user_company in (\'\',0))) ORDER BY full_name')
1 /home/.eeney/johnalan/johnalan.org/dotproject/includes/db_connect.php:112 db_exec('SELECT DISTINCT(user_id), CONCAT_WS(\', \', user_last_name, user_first_name) as full_name FROM users
LEFT JOIN permissions ON user_id = permission_user
WHERE permission_value IS NOT NULL
AND (user_id=2 or ( user_company in (\'\',0))) ORDER BY full_name')
2 /home/.eeney/johnalan/johnalan.org/dotproject/modules/mileagelog/addedit.php:74 db_loadhashlist('SELECT DISTINCT(user_id), CONCAT_WS(\', \', user_last_name, user_first_name) as full_name FROM users
LEFT JOIN permissions ON user_id = permission_user
WHERE permission_value IS NOT NULL
AND (user_id=2 or ( user_company in (\'\',0))) ORDER BY full_name')
3 /home/.eeney/johnalan/johnalan.org/dotproject/style/default/overrides.php:83 require('/home/.eeney/johnalan/johnalan.org/dotproject/modules/mileagelog/addedit.php')
4 /home/.eeney/johnalan/johnalan.org/dotproject/modules/mileagelog/index.php:28 show()
5 /home/.eeney/johnalan/johnalan.org/dotproject/index.php:324 require('/home/.eeney/johnalan/johnalan.org/dotproject/modules/mileagelog/index.php')
Unknown column 'user_last_name' in 'field list'

[pedroa]

Ah, yes that problem... now I remember...
This first_name last_name problem and the permissions table problem... right...

Well there is a block of code around lines 69 to 71 (maybe) of modules/mileagelog/addedit.php that start with:
$sql.....
and
$sql.=......

should be changed to:

$sql = "SELECT DISTINCT(user_id), CONCAT_WS(', ', contact_last_name, contact_first_name) as full_name FROM users ";
$sql.="LEFT JOIN contacts ON user_contact = contact_id ";
$sql.="AND (user_id=".$AppUI->user_id." or (".getPermsWhereClause("companies", "user_company").")) ORDER BY full_name";


And while we are talking about this problem, it will also appear in the modules/mileagelog/vw_mileagelog.php around lines 151 to 153 (maybe), with the exact same starting ($sql=...blah blah blah) change that to:

$sql = "SELECT DISTINCT(user_id), CONCAT_WS(', ', contact_last_name, contact_first_name) as full_name FROM users ";
$sql.="LEFT JOIN contacts ON user_contact = contact_id ";
$sql.="AND (user_id=".$AppUI->user_id." or (".getPermsWhereClause("companies", "user_company").")) ORDER BY full_name";


I guess that's all, anything else?

Pedro A.

[gwp-1]

Very good, very good... that brings up the NEW/UPDATE LOG but... above the log entry formatting is this:

ERROR: /home/.eeney/johnalan/johnalan.org/dotproject/includes/main_functions.php(32): arraySelect called with no array
Backtrace:
0 /home/.eeney/johnalan/johnalan.org/dotproject/includes/main_functions.php:32 dprint('/home/.eeney/johnalan/johnalan.org/dotproject/includes/main_functions.php',32,0,'arraySelect called with no array')
1 /home/.eeney/johnalan/johnalan.org/dotproject/modules/mileagelog/addedit.php:189 arrayselect(NULL,'mileage_log_user_id','','2')
2 /home/.eeney/johnalan/johnalan.org/dotproject/style/default/overrides.php:83 require('/home/.eeney/johnalan/johnalan.org/dotproject/modules/mileagelog/addedit.php')
3 /home/.eeney/johnalan/johnalan.org/dotproject/modules/mileagelog/index.php:28 show()
4 /home/.eeney/johnalan/johnalan.org/dotproject/index.php:324 require('/home/.eeney/johnalan/johnalan.org/dotproject/modules/mileagelog/index.php')

[pedroa]

There where two lines on both those files that were in the middle of the $sql starting lines that are like this:


LEFT JOIN permissions ON user_id = permission_user
WHERE permission_value IS NOT NULL


You must remove them, or else your $users array will not be well populated, in fact in your case it returned NULL, that's why it is broke. (Both files please, ok?)

I know the lines didn't start with $sql but they were in the middle of the darn thing... by the way the permissions table is thing of dP 1 past, not from dP 2 so it would never work.

Pedro A.

[gwp-1]

Ack. Ok, I'm new, bear with me.

Here's what I have in vw_mileagelog.php

// list active users
$sql = "SELECT DISTINCT(user_id), CONCAT_WS(', ', contact_last_name, contact_first_name) as full_name FROM users ";
$sql.="LEFT JOIN contacts ON user_contact = contact_id ";
$sql.="AND (user_id=".$AppUI->user_id." or (".getPermsWhereClause("companies", "user_company").")) ORDER BY full_name";
?>

Here's what I have in addedit.php

$sql = "SELECT DISTINCT(user_id), CONCAT_WS(', ', contact_last_name, contact_first_name) as full_name FROM users ";
$sql.="LEFT JOIN contacts ON user_contact = contact_id ";
$sql.="AND (user_id=".$AppUI->user_id." or (".getPermsWhereClause("companies", "user_company").")) ORDER BY full_name";

$delete_msg = "hello hi";
?>


I removed the offending code, added the new code and got this:

ERROR: /home/.eeney/johnalan/johnalan.org/dotproject/includes/main_functions.php(32): arraySelect called with no array
Backtrace:
0 /home/.eeney/johnalan/johnalan.org/dotproject/includes/main_functions.php:32 dprint('/home/.eeney/johnalan/johnalan.org/dotproject/includes/main_functions.php',32,0,'arraySelect called with no array')
1 /home/.eeney/johnalan/johnalan.org/dotproject/modules/mileagelog/addedit.php:189 arrayselect(NULL,'mileage_log_user_id','','2')
2 /home/.eeney/johnalan/johnalan.org/dotproject/style/default/overrides.php:83 require('/home/.eeney/johnalan/johnalan.org/dotproject/modules/mileagelog/addedit.php')
3 /home/.eeney/johnalan/johnalan.org/dotproject/modules/mileagelog/index.php:28 show()
4 /home/.eeney/johnalan/johnalan.org/dotproject/index.php:324 require('/home/.eeney/johnalan/johnalan.org/dotproject/modules/mileagelog/index.php')

[jbresler]

I've installed it. I used Pedro's mod in the setup... the mileage log seems to work correctly, but only for the current user. I cannot select any other users account to view or edit their mileage logs.

[pedroa]

I had no problem with changing others logs, maybe something to do with the minimum user level in the mod configuration just like timecard?

Pedro A.

[jbresler]

Sorry for the confusion.. I totally missed page 3 on this forum. so, I've now updated with the latest and greatest code from Pedro and it's working accept, the dropdown for the other users mileagelogs doesn't display names... it has the container for the users... but they are all blank accept my own name. I tested that I can see others mileagelogs, but I can't tell who's log it is because the name doesn't show.
Hope that's clear.

JB

[pedroa]

container, you mean combo box, right?
This seems to be a configuration issue, and now I see why is that.
The permission is based on the user type and since it has an inverted order things don't go down to well with the none or blank config value of mileagelog because those are defined like 0 and -1 which in this case means a higher permission than Administrator which does not exist!

So we have to reformulate the modules/mileagelog/configure.php like this:

change line 18 to:

$user_types = arrayMerge( $utypes, array( '9' => $AppUI->_('None') ) );


lines 26, 32 and 38 to:

'value' => 9,


and last but not least line 87 to:

$val = (isset($_POST[$key]) && $_POST[$key]<>"0")?$_POST[$key]:"9";


Now, go to you System Admin., Modules, configure Mileage Logs, edit to your likings and save.

If you try now with a rightfull user, all should be ok.

Pedro A.

[gwp-1]

Ok, completely uninstalled the whole mileage module, deleted the folder from my server. Untarred the tarball from scratch, re-edited the files as indicated in Pedro's threads including the configuration mod.

This is what I get for the USER portion of the NEW/UPDATE LOGS tab:

ERROR: /home/.eeney/johnalan/johnalan.org/dotproject/includes/main_functions.php(32): arraySelect called with no array
Backtrace:
0 /home/.eeney/johnalan/johnalan.org/dotproject/includes/main_functions.php:32 dprint('/home/.eeney/johnalan/johnalan.org/dotproject/includes/main_functions.php',32,0,'arraySelect called with no array')
1 /home/.eeney/johnalan/johnalan.org/dotproject/modules/mileagelog/addedit.php:187 arrayselect(NULL,'mileage_log_user_id','','2')
2 /home/.eeney/johnalan/johnalan.org/dotproject/style/default/overrides.php:83 require('/home/.eeney/johnalan/johnalan.org/dotproject/modules/mileagelog/addedit.php')
3 /home/.eeney/johnalan/johnalan.org/dotproject/modules/mileagelog/index.php:28 show()
4 /home/.eeney/johnalan/johnalan.org/dotproject/index.php:324 require('/home/.eeney/johnalan/johnalan.org/dotproject/modules/mileagelog/index.php')


Please advise. I've done all according to thread, what gives? Granted I'm new to this all, but c'mon... even a monkey can follow directions and I gotta at least be on par with a monkey!



j

[pedroa]

Looks like the mountain gave birth to a ...monkey?

gwp-1,

The problem is with the $users not being populated, what can go wrong:

1st)
SELECT DISTINCT(user_id), CONCAT_WS(', ', contact_last_name, contact_first_name) as full_name FROM users
LEFT JOIN contacts ON user_contact = contact_id

If your users don't have contact data nothing comes up from this, so verify you have contacts and they have a user account and/or vice-versa.

2nd) The monkey here forgot that the WHERE clause was swallowed by the copy/paste and this line:

$sql.="AND (user_id=".$AppUI->user_id." or (".getPermsWhereClause("companies", "user_company").")) ORDER BY full_name";

should be

$sql.="WHERE (user_id=".$AppUI->user_id." or (".getPermsWhereClause("companies", "user_company").")) ORDER BY full_name";

on both files.

Try now this monkey bussiness, I will be sending this mod into the CVS shortly, so your feedback is most welcome, since I would like to upload a better module in the first place.

Guess the monkey was in the wrong zoo after all, sorry...

Pedro A.

[gwp-1]

Ok, did the mods first thing this morning and got this on the NEW/UPDATE tab:

ERROR: /home/.eeney/johnalan/johnalan.org/dotproject/includes/main_functions.php(32): arraySelect called with no array
Backtrace:
0 /home/.eeney/johnalan/johnalan.org/dotproject/includes/main_functions.php:32 dprint('/home/.eeney/johnalan/johnalan.org/dotproject/includes/main_functions.php',32,0,'arraySelect called with no array')
1 /home/.eeney/johnalan/johnalan.org/dotproject/modules/mileagelog/addedit.php:187 arrayselect(NULL,'mileage_log_user_id','','2')
2 /home/.eeney/johnalan/johnalan.org/dotproject/style/default/overrides.php:83 require('/home/.eeney/johnalan/johnalan.org/dotproject/modules/mileagelog/addedit.php')
3 /home/.eeney/johnalan/johnalan.org/dotproject/modules/mileagelog/index.php:28 show()
4 /home/.eeney/johnalan/johnalan.org/dotproject/index.php:324 require('/home/.eeney/johnalan/johnalan.org/dotproject/modules/mileagelog/index.php')



Also, something odd as well, when I try to assign a TASK ID to the mileage entry as it requires, clicking on the SEARCH... button opens a new browser window and takes me to the CONTACTS page! lol Am I missing a point there or is that a result of the messup above?

[pedroa]

But the first page is ok?
If so you forgot to change the AND/WHERE issue we spoke before in the addedit.php file.

About the task selector, I must see first, I normally use this against the observation field instead of the others (task or helpdesk item), you can select this in the configuration.

Pedro A.

[gwp-1]

Here's the exact code copied out of the addedit.php file currently in use:

$sql = "SELECT DISTINCT(user_id), CONCAT_WS(', ', contact_last_name, contact_first_name) as full_name FROM users ";
$sql.="LEFT JOIN contacts ON user_contact = contact_id ";
$sql.="WHERE (user_id=".$AppUI->user_id." or (".getPermsWhereClause("companies", "user_company").")) ORDER BY full_name";$delete_msg = "hello hi";
?>

[pedroa]

weeeee...

Your copy/paste swallowed this line:

$users = db_loadHashList($sql);

so the last lines should be:

$sql.="WHERE (user_id=".$AppUI->user_id." or (".getPermsWhereClause("companies", "user_company").")) ORDER BY full_name";
$users = db_loadHashList($sql);

$delete_msg = "hello hi";


That's why $users is NULL

Go go go...

Pedro A.

[gwp-1]

AWESOME! It works!

Ok, so now to the question of the PURPOSE... when I click SEARCH... button it takes me to Contacts page?

Monkey is confused.

:-)

[pedroa]

Monkey is confused.

:-)

Here goes a banana, just don't step it...

Insert this on line 168 of addedit.php:

function setTask( key, val ) {
var f = document.addedit;

if (val != '') {
f.task_mileage_log_purpose_id.value = key;
f.task_mileage_log_purpose_relation_id.value = key;
f.task_mileage_log_purpose_note.value = val;
}
}


Shoul be right BEFORE the:

</script>


Now lines numbering is a bit different so change line 236 to:

<input type="text" class="text" size="13" maxlength="10" name="task_mileage_log_purpose_relation_id" value="<?=$task_mileage_log_purpose->mileage_log_purpose_relation_id?>"/>&nbsp;<input type="button" class="button" value="<?=$AppUI->_('search...')?>" onclick="javascript:window.open('./index.php?m=public&a=selector&callback=setTask&table=tasks&dialog=1', 'selector', 'left=50,top=50,height=250,width=400,resizable');"/><br>


You should overwrite that line, it is right before this one:

<textarea name="task_mileage_log_purpose_note" cols="60" rows="3" wrap="virtual" class="textarea" readonly><?=dPFormSafe($task_desc)?></textarea>


Uga Buga...

Pedro A.

[gwp-1]

Ok, this mod works perfectly!

Here's the only quirk: When selecting a TASK ID, if you select [none] it enters TASK ID "0" and upon hitting the SAVE button you receive the error pop-up "Please enter a purpose"... basically, it doesn't consider the option NONE to be a valid Task ID.

Otherwise.. I've actually entered a log entry and had it work perfectly! Nice job Pedro!

THIS monkey learned alot from ya this morning!




j

[gwp-1]

Ok, another little quirk:

When trying to delete a log entry, the following error takes place...

Line: 167
Char: 3
Error: Object doesn't support this property or method
http://..../dotproject/index.php?m-mileagelog&tab=1&mid=1

And it doesn't delete.

[jbresler]

Thanks Pedro for your expertise. I appreciate all your help. I'm still not sure what's happening here. I've updated the config file and the combo box is still blank... The combo box works...just that you can't see the users name. You can select a blank in the combo box and get the info from that users mileagelog.

I too cannot delete a log.

Thanks,
JB

[pedroa]

Thanks jbresler for your input,

I will solve the delete issue and then send it to CVS, since my users appear, you will be able to checkout the CVS and solve your problem, ok?

You will probably have to wait for sourceforge to update their servers, that is usually 9 hours, understand this is not my fault, so blame it on the sf monkey, or the system or the globalization or whatever you like most, but not me.

Pedro A.

[gwp-1]

Hey Pedro, I can't seem to find anything at all pertaining to the MILEAGE LOG MODULE in the CVS. Can you provide a link perhaps?

thanks!


j

[pedroa]

Sorry, been working in the core.
I will be uploading between today and tomorrow, so stay tuned...
It will be in dotmods CVS here:
http://cvs.sourceforge.net/viewcvs.py/dotmods/

Pedro A.

[pedroa]

FYI:
It is available now (wait for sourceforge server synch) on CVS...

Pedro A.

[jbresler]

I've updated with CVS and I still couldn't get the names in the dropdown box... but then I added another user and noticed that her name was in the dropdown box... so I did a bit of research and found that all my users have a user_company of 1 in the users table and the new user had a company of 0. I've since changed all the users to have 0 in user_company. Now they have populated the dropdown box. This seems to be working properly and other modules seem to be working properly as well. So, now there's only one issues left that I can tell... I cannot delete mileage logs.
JB

[pedroa]

Thanks for noticing that company thing,

I will be looking for it, and that delete bug too.

Pedro A.

[gwp-1]

Heyyyyyyyyyyyyyy Pedro, just checkin' in and seeing if you'd managed to hunt down and destroy that little "delete" bug yet. No hurry, just curious.

Thanks!

[PaulAndrews91]

Hi Pedro...

I'm using dotProject 2.0.1 on PHP 5.0.4 on a Win32 machine.

I downloaded the latest version of the Mileage Mod, installed it, configured it, but when I ran it I get:

Fatal error: Cannot use object of type dPacl as array in D:\wwwroot\dp\modules\mileagelog\mileagelog.class. php on line 32

on vw_mileagelog.php

and:

Fatal error: Cannot use object of type CMileageLog as array in D:\wwwroot\dp\modules\mileagelog\addedit.php on line 61

on addedit.php

I'm assuming that this is because I'm using PHP 5.

I can remove the error by using the -> notation but obviously I don't want to tamper with something I don't fully understand.

Any thoughts?

Is there a reason you chose not to use the existing acl_check functions?

Regards, Paul.

[pedroa]

gwp-1:
I fell asleep on MileageLog a bit, I have to kill this javascript bug of the delete.

Paul:

You downloaded?... not good.

Please check here:

http://cvs.sourceforge.net/viewcvs.py/dotmods/mileagelog/

Those lines of error/code don't make sense according to the new lines.
about acl_check, I am trying to put the modules to work first correctly under dP 2, then I'll go for permission checking, and dbquery and.......

Pedro A.

[PaulAndrews91]

Pedro,
sorry...I should have been clearer: I did download the files from the CVS source.
Any thoughts on the errors?

Regards, Paul.

PS. We're really keen on the Mileage Module as traditionally we've been messing around with Excel.

[pedroa]

I see now.

This is the part were the new permission system should come up, and the logic is still dP 1 for permission handling in MileageLogs.

I have to reformulate it...

I the meantime verify that your user has a company defined and post back please, thanks.

I say again, MileageLogs is still not dP 2 totally frameworked, ok?


Pedro A.

[PaulAndrews91]

Pedro,

All Users have been assigned to a company.

I'll sit tight until such times as you've had the opportunity to update the mod.

Thanks for your quick replies.

Regards, Paul.

[alraaayeq1]

I am sorry if this dummy question!!, but I have downloaded it and installed it successfully yet I dont know where is that tab/button I can use this from..

I could not find any readme.xxx files.

No description I could found for this mod ...



please help.

[dmader]

I hope someone can help me with my problem. I installed the mileage log. I have a couple of problems. When I add a new record through New/Update the screen will go white and display "0". I never stores the record. Second issue is that the Help Desk Item ID - search takes me to the Contacts. How can I get it to display a list of the Help Desk Items. I hope this is not a repeat issue. I've searched and couldn't find a post like mine.

Thanks for the help in advance.
Don

[madow]

dmader,

Did you ever get a resolution to this problem? I have the same issue and wondered if a solution has been found.

Thanks

Mike

I hope someone can help me with my problem. I installed the mileage log. I have a couple of problems. When I add a new record through New/Update the screen will go white and display "0". I never stores the record. Second issue is that the Help Desk Item ID - search takes me to the Contacts. How can I get it to display a list of the Help Desk Items. I hope this is not a repeat issue. I've searched and couldn't find a post like mine.

Thanks for the help in advance.
Don

[dmader]

Mike,

No I didn't. Please let me know if you find a fix. I'm a bit blind when it comes to PHP.

Thanks

Don

[lmlm]

Mike and Don
Have you found a solution, I got same problem.

"I hope someone can help me with my problem. I installed the mileage log. I have a couple of problems. When I add a new record through New/Update the screen will go white and display "0". I never stores the record. Second issue is that the Help Desk Item ID - search takes me to the Contacts."

Thanks

Mo

[achterberg]

I downloaded the mileage logs mod from the CVS, but I am getting errors similar to PaulAndrews91 (I'm also using php 5, I know not supported). Is there a newer version or has this issue been resolved?

Thanks,

[icabod]

Hey guys,

I know this may be a little late, but I found this great program. It's a free mileage log generator. www.mileagepal.com

Regards,
Icabod

[lmlm]

I am come back with MileageLog.
I had try to run it on 2.04 and I 've always got "0" when I record.
(Php4)

I now try on the rc1 version, and I got this message:
- In the MileageLog:
"Fatal error: Cannot use object of type dPacl as array in \xampp\htdocs\dotproject2\modules\mileagelog\milea gelog.class.php on line 32"
- In the New/Update Log
"Fatal error: Cannot use object of type CMileageLog as array in \xampp\htdocs\dotproject2\modules\mileagelog\added it.php on line 61"
(Php5 and xampp as web development server)

I have try to understand where errors occurs all case but in vain.

Can someone guide us to solve these case.

[caseydk]

Is this module on dotmods?

[pedroa]

Yes.

Pedro A.

[lmlm]

I have found very usefull to be able to attach all resources and trips to project. Here we can not used it.

[diavolorosso]

Hello world,

I installed the mileagelog module for dotProject, i read this forum but i have the same problem with you.. it's always posted "0"

everybody found a solution for this problem ?

I work with dotProject 2.0.4

Thanks you very much,
Tom

[diavolorosso]

UP
please ;)

[samuraitux]

Has any one got a fix for the issue with the page displaying 0 after hitting save. I have tried everything and I can't seem to find the issue. Any Help would be greatly appreciated.

[lmlm]

I was also looking for update.
Infact these module was done for dotproject 1 and was not more following in version 2